Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sample_rate property and fix test_monitor #3790

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

sl0thentr0py
Copy link
Member

No description provided.

Copy link

codecov bot commented Nov 15, 2024

❌ 1567 Tests Failed:

Tests completed Failed Passed Skipped
19893 1567 18326 4413
View the top 1 failed tests by shortest run time
tests.test_scope test_with_isolation_scope
Stack Traces | 0.001s run time
tests/test_scope.py:357: in test_with_isolation_scope
    assert scope is in_with_isolation_scope
E   assert <PotelScope id=0x7fadb7ac37a0 name=None type=ScopeType.ISOLATION> is <Scope id=0x7fadbc097920 name=None type=ScopeType.ISOLATION>
View the full list of 2 ❄️ flaky tests
tests.test_scope test_with_isolation_scope_data

Flake rate in main: 99.17% (Passed 2 times, Failed 239 times)

Stack Traces | 0.001s run time
tests/test_scope.py:387: in test_with_isolation_scope_data
    assert scope._tags == {"before_isolation_scope": 1}
E   AssertionError: assert {} == {'before_isolation_scope': 1}
E     
E     Right contains 1 more item:
E     {'before_isolation_scope': 1}
E     
E     Full diff:
E     + {}
E     - {
E     -     'before_isolation_scope': 1,
E     - }
tests.test_scope test_with_new_scope

Flake rate in main: 97.03% (Passed 8 times, Failed 261 times)

Stack Traces | 0.001s run time
tests/test_scope.py:587: in test_with_new_scope
    assert scope is in_with_current_scope
E   assert <PotelScope id=0x7f91040d4400 name=None type=ScopeType.CURRENT> is <Scope id=0x7f91040f1f20 name=None type=ScopeType.CURRENT>

To view more test analytics, go to the Test Analytics Dashboard
Got feedback? Let us know on Github

@sl0thentr0py sl0thentr0py merged commit b2b6315 into potel-base Nov 18, 2024
43 of 123 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/potel/fix-test-monitor branch November 18, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants